search

ome / omero-dropbox

OMERO.dropbox server for watching directories
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
1 stars 6 forks source link

Review all instances of whitelist/blacklist #16

Open joshmoore opened 4 years ago

joshmoore commented 4 years ago

This does not try to maintain backwards compatibility since the related methods and classes are internal. The likeliest impact is that of the change in property name. A redirecting property could be added here, but a nicer choice is likely to automatically upgrade in omero-py.

see: https://github.com/ome/bioformats/issues/3580

pwalczysko commented 4 years ago

failed travis

joshmoore commented 4 years ago

Now omero-test-infra is failing. This touches Ice and is going to be harder than expected:

(base) /opt/omero-build/omero-blitz $git grep -E "(black|white)list"
src/main/slice/omero/FS.ice:         * @param whitelist list of files or extensions of interest (Ice::StringSeq).
src/main/slice/omero/FS.ice:         * @param blacklist list of directories, files or extensions that are not of interest (Ice::StringSeq).
src/main/slice/omero/FS.ice:                                Ice::StringSeq whitelist,
src/main/slice/omero/FS.ice:                                Ice::StringSeq blacklist,

cc: @sbesson

sbesson commented 4 years ago

Very unfortunate. So even if the type/signature is identical, the name of the parameters in the .ice generating classes would need to be jointly renamed? If so, I wonder if this is something we want to test as we are about to cut release of the OMERO java components (and maybe deprecating the old method to prevent other breakages?)

joshmoore commented 4 years ago

Yes to all. We could also deprecate the fields in Ice. Not sure we want add the new fields at this point or not.