ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO
http://figure.openmicroscopy.org
GNU Affero General Public License v3.0
15 stars 31 forks source link

update OMERO version #180

Closed atarkowska closed 8 years ago

atarkowska commented 8 years ago

see https://trello.com/c/cyoBblgp/200-renaming-of-web-app#comment-5803f1d6c2f5c7db6f370fc2

jburel commented 8 years ago

I don't think that is right. it will not be limited to 5.2.6+ 4.4 can certainly be dropped.

atarkowska commented 8 years ago

I am not sure I understand, Figure 2.0+ is compatible with 5.2.6+, otherwise urls are broken. That's being said, older version of OMERO are only supported with 1.x line. Is that not why we branched off and rebased https://github.com/openmicroscopy/openmicroscopy/pull/4856?

jburel commented 8 years ago

I have, for example, installed figure using pip (see https://github.com/ome/omero-figure/pull/181) on docker with omero 5.2.4.

I will rework the readme since i think it is better to have the instruction included in so it is readable on pypi instead of pointing to figure.openmicroscospy.

are you okay to close this PR?

atarkowska commented 8 years ago

@jburel and what was the output of:

curl -I http://dockerhost/figure/

?

atarkowska commented 8 years ago

You should get 404:

$ curl -I http://10.x.x.137/figure/
HTTP/1.1 404 NOT FOUND
Server: nginx/1.10.1
Date: Mon, 17 Oct 2016 20:31:10 GMT
Content-Type: text/html; charset=utf-8
Connection: keep-alive

although

$ curl -I http://10.x.x.137/omero_figure/
HTTP/1.1 302 FOUND
Server: nginx/1.10.1
Date: Mon, 17 Oct 2016 20:31:14 GMT
Content-Type: text/html; charset=utf-8
Connection: keep-alive
Vary: Cookie
Location: http://10.x.x.137/webclient/login/?url=%2Fomero_figure%2F

I am afraid we should clarify that. Could you cherry-pick into #181?

jburel commented 8 years ago

similar: but the way I read things is that figure is incompatible with older version. It can still be installed. I think we need to review all the readme (weberror, gallery etc.)

jburel commented 8 years ago

Agree that we need to clarify. I will work on the readme and add commit to https://github.com/ome/omero-figure/pull/181

jburel commented 8 years ago

Closing this PR, clarification added to #181