remove_create_original_file_from_file_obj

ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO

http://figure.openmicroscopy.org

GNU Affero General Public License v3.0

15 stars 31 forks source link

remove_create_original_file_from_file_obj #239

Closed will-moore closed 6 years ago

will-moore commented 7 years ago

This removes the local Figure method create_original_file_from_file_obj() and uses the Blitz Gateway copy of the same method.

To test, check that saving a figure works OK.

waxenegger commented 7 years ago

Opened image, added shape and label to then store it. After closing figure and opening the stored file everything I added was there. Working as expected.

joshmoore commented 6 years ago

Does this place any version restrictions on figure that weren't already in place?

will-moore commented 6 years ago

@joshmoore No, we already require OMERO 5.3.0 and that has this method: https://github.com/openmicroscopy/openmicroscopy/blob/v5.3.0/components/tools/OmeroPy/src/omero/gateway/__init__.py#L3798

joshmoore commented 6 years ago

Cheers.

jburel commented 6 years ago

removed exclude comment

snoopycrimecop commented 6 years ago

Conflicting PR. Removed from build FIGURE-merge#604. See the console output for more details. Possible conflicts:

Upstream changes
- omero_figure/views.py

~~--conflicts~~ Conflict resolved in build FIGURE-merge#605. See the console output for more details.