search

ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO
http://figure.openmicroscopy.org
GNU Affero General Public License v3.0
15 stars 31 forks source link

export_bug_dx_None #257

Closed will-moore closed 6 years ago

will-moore commented 6 years ago

See https://trello.com/c/0TnhjDrs/1-export-bug-dx-none

This fixes a rarely seen bug (not sure how to reproduce it in normal use) in figure export. Check that figure export still works as expected, with some images zoomed in and panned off-centre. Check cropped region is same in exported figure as in web.

will-moore commented 6 years ago

@jburel Added default variable.

jburel commented 6 years ago

If you could also change if dx > 0: to if dx>DEFAULT_OFFSET same for dy

will-moore commented 6 years ago

In that case, we really just need to know if dx is positive or negative and this has nothing to do with the default offset. E.g. if the default offset was 100, we'd still need to know that dx is positive (not if it was different from 100).

jburel commented 6 years ago

understood everything seems to work now merging