file_open_menu

[will-moore]

From comment on testing sheet https://docs.google.com/spreadsheets/d/1qdOAv0wUgAVHEtlVroOwkeNUoNwst-APSPFJk6-3Sz8/edit#gid=0 "* File menu. When clicking on an item, a dialog pops up. To be consistent with Save a Copy... All entries should have ... e.g. Open ..."

This PR adds the 3 dots to the commands which are incomplete (need other options chosen in a dialog). These are Open... and Import from JSON...

Also, improved layout of the drop-down menu options that have keyboard shortcuts, aligning the shortcut keys to the right of each menu.

To test:

• Check the File and Edit menus looks OK on Mac
• Check that on Windows the shortcut keys show Ctrl+N instead of apple key.

[pwalczysko]

Bug: On Mac Firefox, I have the shortcuts to the right of each line, but unfortunately, on a new line.

Note: This is fine on Mac Chrome and Mac Safari and Win7 IE11.

Win7 Firefox shows the same bug as Mac Firefox.

Looks like FF specific issue

[pwalczysko]

RFE: Unify capitalization of Save A Copy -> in line with Export as json, where the as is lower case a, the A in Save A Copy should be lower case too.

[pwalczysko]

RFE: @will-moore mentioned that the capitalization of the word json is different from the common usage -> rectify this please.

[mtbc]

The Mac detection seems rather broken: it's even showing the weird Mac four-loop symbol on Linux, both Firefox and Chrome. Maybe outwith this PR though.

[will-moore]

@mtbc Oh, yes - I didn't even consider Linux. The default is to show Mac shortcut keys, and I detect Windows to show Ctrl+X. But I guess Linux should show the same as Windows (Ctrl+X)?

[mtbc]

Yes, Ctrl+ would be good for Linux: maybe detect Mac to show its weird thing and Ctrl otherwise. Can be addressed in a separate PR.

[pwalczysko]

The layout on FF https://github.com/ome/omero-figure/pull/283#issuecomment-384275553 and the capitalization https://github.com/ome/omero-figure/pull/283#issuecomment-384279720 work as expected on Mac and Win7 FF and Chrome and IE11.

Interestingly, the Ctrl + N shortcut is unusable, instead of opening a new figure, this will open a new browser window.

[will-moore]

Ah, yes @jburel reported that too, on the testing sheet. It's a known issue - browsers won't allow it https://github.com/ccampbell/mousetrap/issues/159 so I'll just remove the shortcut keys from "New"

[mtbc]

From Linux got Ctrl+ now, great! :+1:

[pwalczysko]

Works fine on Win7 IE11, FF and Chrome. Works fine on mac FF, Chrome and Safari.

Ready to merge FMPOV

[jburel]

Save when active pops up a dialog so it should be Save... Export as JSON too => Export as JSON

We still have json in both dialog for Export and Import. This could be updated to match the entry in the menu

[will-moore]

Save doesn't open a dialog (unless previously unsaved) so doesn't need .... Added dots to Export as JSON... and fixed json -> JSON in dialog title and text.

[jburel]

Looks good Save is tricky since it will pop a dialog for unsaved figure. Let's keep it as Save. Merging