search

ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO
http://figure.openmicroscopy.org
GNU Affero General Public License v3.0
15 stars 30 forks source link

use of `Export_Option` in FigureExport #290

Open carandraug opened 6 years ago

carandraug commented 6 years ago

This is not a big issue, it's only the redudancy on the client that has to do:

TiffExport(conn, {'Export_Option' : 'TIFF', ...}, ...)

The option Export_Option in the Figure_To_Pdfscript is used to create a FigureExport or TiffExport object. It is then used again in FigureExport.build_figure to decide whether to create a zip file (it will create a zip file if exporting to a tiff file and there's multiple pages). However, that information is already in whether this is a TiffExport object. Having a class property like 'supports_multipage_per_file' would avoid that redudancy (although the TIFF does support multiple pages per file).

will-moore commented 6 years ago

Thanks for the suggestion. This will also be part of https://trello.com/c/8vNGPi2n/190-export-without-scripting-service so I'll link to this from that card.