search

ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO
http://figure.openmicroscopy.org
GNU Affero General Public License v3.0
15 stars 30 forks source link

fix invalid panel dx/dy offsets #294

Closed carandraug closed 6 years ago

carandraug commented 6 years ago

After parsing the JSON string, check if it's valid and fix it where we can. Fixes issue #292

will-moore commented 6 years ago

I've not tested yet but looks good. We will be releasing figure 4.0.0 very soon so this won't go into that release I'm afraid. I just noticed travis failed:

./omero_figure/scripts/omero/figure_scripts/Figure_To_Pdf.py:651:9: E266 too many leading '#' for block comment
./omero_figure/scripts/omero/figure_scripts/Figure_To_Pdf.py:652:9: E266 too many leading '#' for block comment
carandraug commented 6 years ago

I've not tested yet but looks good. We will be releasing figure 4.0.0 very soon so this won't go into that release I'm afraid.

No problem. We already are using a modified version of the script that skips the annotation after the build.

I just noticed travis failed:

I have changed the comment style to follow pep 8