ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO
http://figure.openmicroscopy.org
GNU Affero General Public License v3.0
15 stars 30 forks source link

Default image viewer is figure, or iviewer #302

Closed will-moore closed 5 years ago

will-moore commented 6 years ago

This is an idea that could improve the workflow where we use Images of a figure to organise figures in OMERO (see https://github.com/openmicroscopy/design/issues/96).

If we configure the default viewer of webclient to be OMERO.figure:

$ bin/omero config set omero.web.viewer.view omero_figure.views.figure_image_viewer

now, when an image is double-clicked in webclient, we test to see if it has been exported from Figure (does it have the OMERO.figure URL in description)? If so, we redirect to open the original figure in OMERO.figure. Otherwise we simply open the image in iviewer as normal (or webgateway viewer if iviewer not installed).

To test:

cc @jstitlow

jburel commented 6 years ago

This is an interesting idea. A problem i can see with the current strategy is that if the "default" viewer is not iviewer e.g. pathviewer, the image will pop up in the old gateway viewer. This will be annoying

will-moore commented 6 years ago

@jburel Yes, that's always going to be a problem with any conditional opening of an image viewer. E.g. if 3D image open in FPBioimage else open in....? I guess you could have 2 views.py methods figure_image_viewer_or_iviewer and figure_image_viewer_or_pathviewer and then the config above could choose which you want $ bin/omero config set omero.web.viewer.view omero_figure.views.figure_image_viewer_or_*