ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO
http://figure.openmicroscopy.org
GNU Affero General Public License v3.0
15 stars 31 forks source link

Support for large floating-point images #317

Open sbesson opened 5 years ago

sbesson commented 5 years ago

See https://www.openmicroscopy.org/community/viewtopic.php?f=5&t=8630

Large floating-point images are a known limitation of the OMERO pyramid generation.

Such images will now open in OMERO.figure probably as per the support for large XY images. However as demonstrated in the forum post, the script export functionality currently fails because of this line:

https://github.com/ome/omero-figure/blob/cfa06bd7eb0416d8835c515f34f34ffc3c7731a0/omero_figure/scripts/omero/figure_scripts/Figure_To_Pdf.py#L1334-L1337

The condition for calling the render_big_image_region codepath in the export script is

https://github.com/ome/omero-figure/blob/cfa06bd7eb0416d8835c515f34f34ffc3c7731a0/omero_figure/scripts/omero/figure_scripts/Figure_To_Pdf.py#L1324-L1327

However the condition for having non-null zoom levels returned by the BlitzGateway is

https://github.com/openmicroscopy/openmicroscopy/blob/6bed02cffba74ba513ced3d0939235fa7ff2de34/components/tools/OmeroPy/src/omero/gateway/__init__.py#L8528-L8529

which includes the pixel type check in addition to the plane size.

There are a couple of options to address this issue however I am unclear what is the epxected contract and limitations:

lguerard commented 1 year ago

Hi,

We encountered this issue again today with a 32-bit image, is there any workaround to still export the figure ?

Thanks !

lguerard commented 1 year ago

Hi,

We encountered this issue again today with a 32-bit image, is there any workaround to still export the figure ?

Thanks !