ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO
http://figure.openmicroscopy.org
GNU Affero General Public License v3.0
15 stars 30 forks source link

rotate and crop errors #324

Closed jburel closed 3 years ago

jburel commented 5 years ago

From https://www.openmicroscopy.org/community/posting.php?mode=quote&f=4&p=20674 A user here at HMS reported to me that they were having problems with rotated and cropped figures. I was able to reproduce the problem. When you crop a figure that has been rotated the position of the cropping is not consistent with the output you get. The attached screenshot illustrates what is happening. The Preview pane shows what is intended. The resulting figure is offset to the lower left. The problem seems to be in the accuracy of the crop tool. If you reposition the crop frame only slightly, even though it appears to be in the wrong place, the correct crop is possible.

will-moore commented 3 years ago

Mapping from current crop region to Rectangle on rotated image is not taking account of rotation correctly (see screenshot)

Screenshot 2020-12-15 at 13 13 08

And the reverse mapping from crop Rectangle back to crop region on 'OK' also needs to take account of rotation.