export to omero description

ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO

http://figure.openmicroscopy.org

GNU Affero General Public License v3.0

15 stars 30 forks source link

export to omero description #329

Closed will-moore closed 4 years ago

will-moore commented 5 years ago

This improves the description of OMERO images created from figure export. The image description now include references to the images that are contained in the figure (same as the PDF info page does for other forms of figure export). This helps keep track of where an image-of-a-figure comes from.

To test:

export a Figure to OMERO Image
check the description for listing the images in the figure
In Insight, the Image ID: 123 should be rendered as a clickable link.

jburel commented 5 years ago

Image's ID and name are displayed.
The UI could quickly become very clutter. So maybe we should display the ID only and name in the tooltip. Best will be to be able to open the image in iviewer from the ID

Note that insight link is no longer active.

will-moore commented 5 years ago

Unfortunately we don't have the ability to use tooltips etc in the description and if we try to truncate the image name then info will be lost and you could end up with ambiguous names. I think it's better to keep the full name and risk a little clutter than to remove names.

Screen Shot 2019-07-16 at 12 17 15

will-moore commented 5 years ago

You can also improve the readability in the screenshot above by resizing the right panel so that image names don't wrap onto a second line.

jburel commented 5 years ago

Looking at the screenshot I am wondering if we should now have Under Contains Images a list of hyperlinks to the images similar to the link to the figure

will-moore commented 5 years ago

I tried manually editing the description above to see how this looks with links. I tried adding links after the Image ID: 111 for the first few images, and instead of it for the last few images:

Not sure if we want all this? Best would be to have Image ID: 111 be rendered as a link, so maybe we should go for this feature and not add other links that will then be redundant.

jburel commented 5 years ago

Having Image ID rendered as link is the best option. It has been turned off in insight (I cannot remember why)

will-moore commented 5 years ago

OK, so I'll leave it as it is for now with - Image ID: 123 name.

jburel commented 5 years ago

How long will it take to render the ID as link?

will-moore commented 5 years ago

Done https://github.com/openmicroscopy/openmicroscopy/pull/6087

jburel commented 4 years ago

Not possible to test the export option on merge-ci, the control is greyed out: script is not installed

jburel commented 4 years ago

Retested again It works as expected