search

ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO
http://figure.openmicroscopy.org
GNU Affero General Public License v3.0
15 stars 30 forks source link

Channel labels in preview tab #333

Closed will-moore closed 4 years ago

will-moore commented 5 years ago

See https://trello.com/c/QgzoGsmi/195-channel-names-in-preview-panel

Work in progress...

Screen Shot 2019-07-19 at 16 37 06

jburel commented 5 years ago

Ideally the color of the text should also be changed depending on the color of the channel. Black text on dark channel color is not readable.

The font could potential be reduced if the text is too long to be displayed In some cases the name is truncated and there is no indication that's the case

will-moore commented 5 years ago

I've used the same logic we do in the webgateway viewer (originally from Insight) for showing white text if colour is dark. Knowing where to truncate long labels with ... is tricky, depending on which letters you have and you end up showing less of the label than you otherwise would. Full label is shown with tooltip.

jburel commented 5 years ago

Discussed technical option with @will-moore for the text The color is now changed according to the background of the button. Similar changes should be applied to iviewer

will-moore commented 5 years ago

Testing options for handling long channel names: Default view: Screen Shot 2019-08-20 at 10 55 48

With css text-overflow: ellipsis; you lose too much info Screen Shot 2019-08-20 at 11 03 01

Shrinking text to 80% makes it less readable and messes up the height of the buttons. Screen Shot 2019-08-20 at 11 03 39

Conclusion: best to leave it as it is I think.

will-moore commented 5 years ago

cc @dsudar Best way to handle long channel names?

dsudar commented 5 years ago

Hi @will-moore Great that you're addressing this. I quickly checked how iviewer does things. Same as your "default view" and then a tooltip with the full name when you hover. That actually works quite well and would have my preference. And I agree about the text color with @jburel. Thanks, Damir

jburel commented 4 years ago

Thanks @will-moore for investigating, the text display at 80% is too small. So probably better to keep it as it is and have the full name in the tooltip

will-moore commented 4 years ago

Great. We already have the full channel label in tooltip so I think this is good to go.