Closed will-moore closed 4 years ago
Ideally the color of the text should also be changed depending on the color of the channel. Black text on dark channel color is not readable.
The font could potential be reduced if the text is too long to be displayed In some cases the name is truncated and there is no indication that's the case
I've used the same logic we do in the webgateway viewer (originally from Insight) for showing white text if colour is dark.
Knowing where to truncate long labels with ...
is tricky, depending on which letters you have and you end up showing less of the label than you otherwise would. Full label is shown with tooltip.
Discussed technical option with @will-moore for the text The color is now changed according to the background of the button. Similar changes should be applied to iviewer
Testing options for handling long channel names:
Default view:
With css text-overflow: ellipsis;
you lose too much info
Shrinking text to 80% makes it less readable and messes up the height of the buttons.
Conclusion: best to leave it as it is I think.
cc @dsudar Best way to handle long channel names?
Hi @will-moore Great that you're addressing this. I quickly checked how iviewer does things. Same as your "default view" and then a tooltip with the full name when you hover. That actually works quite well and would have my preference. And I agree about the text color with @jburel. Thanks, Damir
Thanks @will-moore for investigating, the text display at 80% is too small. So probably better to keep it as it is and have the full name in the tooltip
Great. We already have the full channel label in tooltip so I think this is good to go.
See https://trello.com/c/QgzoGsmi/195-channel-names-in-preview-panel
Work in progress...