search

ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO
http://figure.openmicroscopy.org
GNU Affero General Public License v3.0
15 stars 30 forks source link

Stroke width paste rect fix #342

Closed will-moore closed 4 years ago

will-moore commented 4 years ago

See https://github.com/ome/omero-figure/issues/341

Fixes Figure export with Rectangles created from copy of crop region and paste to create Rectangle. Previously shapes were created with "lineWidth" attribute instead of "strokeWidth". This is fixed, and we also update previously created files when they are opened. Workflow described in https://forum.image.sc/t/tips-tricks-gifs-from-uca-embrc-france-omero-database/32268

To test:

pwalczysko commented 4 years ago

Failed travis

joshmoore commented 4 years ago

Failure will hopefully be fixed by re-running once https://github.com/ome/omero-test-infra/pull/43 is merged.

joshmoore commented 4 years ago

Removed my temporary VERBOSE="set -x" commit from .travis.yml. With a few pushes to origin/master, omero-test-infra is now passing again.

jburel commented 4 years ago

Not possible to export from py3-ci/web

will-moore commented 4 years ago

Just uploaded the merged script to py3-ci

pwalczysko commented 4 years ago

works as expected.

Ready to merge fmpov