run NPM before build_py

ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO

http://figure.openmicroscopy.org

GNU Affero General Public License v3.0

15 stars 30 forks source link

run NPM before build_py #359

Closed will-moore closed 4 years ago

will-moore commented 4 years ago

Port https://github.com/ome/omero-parade/pull/71 from parade...

To test:

Check py3-ci has figure working

joshmoore commented 4 years ago

https://github.com/ome/omero-figure/blob/7d5bb3155eff68381c1ccd775acef6029e029d07/.omeroci/app-deps runs

npm install -g grunt

Is that needed?

will-moore commented 4 years ago

Even with grunt installed globally, it still fails with Fatal error: Unable to find local grunt. in pip install dist/omero-figure-4.2.dev1.tar.gz. However, the previous python setup.py sdist seems to compile js OK with grunt, File omero_figure/static/figure/figure.js created. etc.

We shouldn't really need grunt in the pip install step.

will-moore commented 4 years ago

Even with the grunt install step, still not being found. In travis failure above...

  npm install
  ...
  npm install -g grunt
  /usr/bin/grunt -> /usr/lib/node_modules/grunt/bin/grunt
  /usr/lib
  `-- grunt@1.0.4

  grunt jst
  grunt-cli: The grunt command line interface (v1.2.0)

  Fatal error: Unable to find local grunt.