Closed will-moore closed 4 years ago
The change itself looks simple enough; :+1: for merging.
I'd like to point out though that there's some overlap in the if
-statements just above and below e.g. a check for if first_img_id is not None:
on 249. Glancing over more of the code, I then saw an "upload file" duplicated on line 286. Similar to @jburel's recent https://github.com/ome/training-scripts/pull/80, I think we will need to start taking the opportunities of these simple fixes to also reduce overall code complexity. This change doesn't make it much harder to read, but in the sum, someone would need to think a bit longer the next time they come back to this section.
OMERO.figure does not seem to work on merge-ci
Figure on merge-ci was temporarily broken by 'Figure CLI' PR. Working now.
Works as expected on merge-ci. Ready to merge fmpov
Fixes #336
To test: