ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO
http://figure.openmicroscopy.org
GNU Affero General Public License v3.0
15 stars 30 forks source link

Fix Save Figure with no panels #363

Closed will-moore closed 4 years ago

will-moore commented 4 years ago

Fixes #336

To test:

joshmoore commented 4 years ago

The change itself looks simple enough; :+1: for merging.

I'd like to point out though that there's some overlap in the if-statements just above and below e.g. a check for if first_img_id is not None: on 249. Glancing over more of the code, I then saw an "upload file" duplicated on line 286. Similar to @jburel's recent https://github.com/ome/training-scripts/pull/80, I think we will need to start taking the opportunities of these simple fixes to also reduce overall code complexity. This change doesn't make it much harder to read, but in the sum, someone would need to think a bit longer the next time they come back to this section.

pwalczysko commented 4 years ago

OMERO.figure does not seem to work on merge-ci

will-moore commented 4 years ago

Figure on merge-ci was temporarily broken by 'Figure CLI' PR. Working now.

pwalczysko commented 4 years ago

Works as expected on merge-ci. Ready to merge fmpov