ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO
http://figure.openmicroscopy.org
GNU Affero General Public License v3.0
15 stars 31 forks source link

fix channel label mismatch #377

Closed will-moore closed 4 years ago

will-moore commented 4 years ago

If multiple images with same number of channels are selected, the channel buttons previously showed "undefined" if the labels didn't match. Now we show no text.

Fixes #364.

Before:

Screenshot 2020-04-18 at 06 51 42

After:

Screenshot 2020-04-18 at 06 51 09
jburel commented 4 years ago

The blank button should be shown if the name of the channel does not match if for example we have 2 images with both DAPI then DAPI should be used instead of a blank button

will-moore commented 4 years ago

That should be how it's working already?

e.g. 2 image selected - First channel is named differently but the other channels have same name in both images:

Screenshot 2020-04-18 at 21 32 22
jburel commented 4 years ago

I thought so, I was a bit confused by the description in the PR

jburel commented 4 years ago
Screenshot 2020-04-22 at 13 25 45
jburel commented 4 years ago
Screenshot 2020-04-22 at 13 29 16
jburel commented 4 years ago

Looks good