search

ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO
http://figure.openmicroscopy.org
GNU Affero General Public License v3.0
15 stars 30 forks source link

Fix negative timestamps format #383

Closed will-moore closed 4 years ago

will-moore commented 4 years ago

Noticed bug with negative timestamps using hh:mm:ss format or mm:ss format since we round the hrs and minutes down in the UI and export script.

To test, check that the timestamps are shown correctly on this figure (screenshot shows current bug) e.g. 0:00:-1 and -1:59:59

Screenshot 2020-05-11 at 00 04 15
jburel commented 4 years ago

Something is out of synch in the display

Screenshot 2020-05-12 at 10 45 54
jburel commented 4 years ago

Check the time values one is -00:00:value one is 00:00:-value

will-moore commented 4 years ago

@jburel Sorry - didn't list this for standup today but 00:00:-value is fixed in right panel. One issue I noticed: If you have a negative time (e.g 100 milliseconds) and you show hh:mm:ss`` or ``hh:mm``, they will currently appear as-00:00:00```, which is technically correct (they are negative) but does that look too wrong?

jburel commented 4 years ago

Right-hand panel now

Screenshot 2020-05-13 at 11 43 54
jburel commented 4 years ago
Screenshot 2020-05-13 at 11 53 51

Having the "negative" zeros do not look good as you say, in that case it should 00:00

jburel commented 4 years ago

This looks better

Screenshot 2020-05-14 at 13 36 16
jburel commented 4 years ago

Outside the scope of this PR but for long lasting timelapse [hrs] and [hrs:mins] will be useful

jburel commented 4 years ago
Screenshot 2020-05-14 at 13 53 44
jburel commented 4 years ago

RFE https://github.com/ome/omero-figure/issues/384