search

ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO
http://figure.openmicroscopy.org
GNU Affero General Public License v3.0
15 stars 30 forks source link

Fix scalebar units in PDF export #412

Closed will-moore closed 3 years ago

will-moore commented 3 years ago

Fixes #406

To test:

Screenshot 2020-12-14 at 14 36 44

jburel commented 3 years ago

export option is disabled. is the export script on merge-ci?

jburel commented 3 years ago

tested using https://merge-ci.openmicroscopy.org/web/figure/file/64877

Screenshot 2021-01-07 at 16 16 41

The feature works, but the order of the scale bars does not corresponds to the order of the display scale bar of the second image is first in the list

will-moore commented 3 years ago

The images in a figure have no order (their position doesn't correspond to their order). I collect the various scalebar lengths from all the images in the figure and only show each unique value, so it's likely that each scalebar applies to many images in different locations. This export of scalebar lengths in the PDF was really needed before we had the ability to add labels to scalebars on the panels. Now that labels are supported (and will be the default with #413) the display of lengths in the PDF is not so important - and not worth spending too much time on improving (this is a bug-fix only).

jburel commented 3 years ago

thanks for the clarification. Merging