Avoid duplicate labels from Key-Values

ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO

http://figure.openmicroscopy.org

GNU Affero General Public License v3.0

15 stars 30 forks source link

Avoid duplicate labels from Key-Values #414

Closed will-moore closed 3 years ago

will-moore commented 3 years ago

Fixes #395

To test:

Add duplicate Key-Value pairs to an Image
Choose that Key when adding labels to the image from key-value pairs.
Only 1 label should be created on each Panel for the duplicate Key-Value pairs.

jburel commented 3 years ago

Discussed with @will-moore, it is currently not possible to add kvp in web using merge-ci. This is currently broken

will-moore commented 3 years ago

@jburel Thanks for finding that. Fixed in open PR: https://github.com/ome/omero-web/pull/225/commits/60dece6ba0fe6d69f5ee1d9d624661df0d7b1c9f

jburel commented 3 years ago

using https://merge-ci.openmicroscopy.org/web/webclient/?show=image-83165 (user-1)

created a duplicate kvp
in figure, only one key listed
I can add the same kvp multiple times (unexpected)
only one entry in the right-hand panel for the kvp (see screenshot)
Click on red cross to remove, remove all the duplicated entries

will-moore commented 3 years ago

Ah, that's a slightly different issue. In that case you have chosen to add the same label repeatedly, which will cause the same issue, regardless of whether it comes from KV pairs, or other metadata or is added manually. I'm not sure that this is really a bug. Although you could consider the batch edit and delete behaviour to be unexpected. But that behaviour has always been the same an no-one has complained so I think it would need more discussion to change it and is outside the scope of #395 so I would prefer to just get the existing fix in for now.