Show group info

[will-moore]

Fixes #284 to show which groups each Figure is in and allow you to chgrp.

To test:

• File > Open list now includes groups and allows you to filter by Group just the same as Owner.
• File > Move Figure to Group... shows a chgrp dialog where you can pick a group to move to. Chgrp should be "instant" (we wait for a response instead of polling for completion) since it's not expected to take long.
• This dialog also shows you which group the images in the figure belong to, with links to the images. This should help to ensure you keep the images and figure in same group.

[imagesc-bot]

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/how-to-get-all-the-projects-and-datasets-of-an-omero-user/47245/2

[pwalczysko]

Simple workflow (first two bullet points in the description) works as described. The third bullet point seems to work too, but

https://merge-ci.openmicroscopy.org/web/figure/file/25179 seems to indicate that the figure has 3 images which belong to the same group. When the "3 images" link is clicked, in the webclient, only 2 images are selected. What am I missing in this particular case ? (login as user-3)

[pwalczysko]

It would be good to be more verbose on the message which indicates in which groups are the images. The implicit message should be made more obvious by stating something like "Note that only a user with permissions to see the images included in the figure will be able to see all the panels inside this figure". Possibly this could be shortened, but the assumption that the user will know the above is not accurrate for many users.

[snoopycrimecop]

Conflicting PR. Removed from build OMERO-plugins-push#639. See the console output for more details. Possible conflicts:

• PR #415 will-moore 'Handle save errors'
  • omero_figure/templates/figure/index.html
  • src/js/views/figure_view.js

--conflicts

[snoopycrimecop]

Conflicting PR. Removed from build OMERO-plugins-push#640. See the console output for more details. Possible conflicts:

• PR #415 will-moore 'Handle save errors'
  • src/js/views/figure_view.js

--conflicts Conflict resolved in build OMERO-plugins-push#652. See the console output for more details.

[pwalczysko]

Not sure what changed here since last testing. Would still go for the more verbose mesage https://github.com/ome/omero-figure/pull/416#issuecomment-756938811 The problme described in https://github.com/ome/omero-figure/pull/416#issuecomment-756927852 is not caused by this PR - interestingly, a link to 3 images when pasted into new browser window will highlight only 2 of those images in the webclient (the 2 ones from the same dataset) and the third one is ignored (not highlighted), see https://merge-ci.openmicroscopy.org/web/webclient/?show=image-64166|image-83221|image-122915

[will-moore]

@pwalczysko Apologies, I missed your previous comments before rebase etc. I added more info to the dialog (see below). For the link to the images, I just wanted a light-weight way that a user could track down the images that were in the "wrong" group, expecting that to be a small number. Eg. see screenshot. I could add a separate link to every image in the figure, but how to do that without it becoming a very bloated dialog (lots of image names etc)? I guess I could use IDs as text to link to individual images? But that could still end up with 20+ links, all to images in the same group you I don't need to find anyway. Or allow user to expand a section of the dialog, but that just takes more time, coding and testing.

[dominikl]

Looks good to me 👍 I think too, that it's better not to overload the dialog.

[pwalczysko]

I think too, that it's better not to overload the dialog.

Yes, this is fine imho, the point is not to put all the links into the dialog, but rather, to explain the concept of the Figure in Group and Images in (another) Group. I think the present state is sufficient.

[jburel]

Merging so we can move forward with #421