Handle save errors2 - Githubissues

ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO

http://figure.openmicroscopy.org

GNU Affero General Public License v3.0

15 stars 30 forks source link

Closed will-moore closed 3 years ago

will-moore commented 3 years ago

This is a follow-up to #415. cc @jburel

NB: this is on top of #416 (needed the new code from that PR), so that should be merged first.

To test:

When a figure is recovered, the figure is cleared from local storage
We use 'sessionStorage' for recovering figures. This is cleared when you quit the browser
Figure is saved in a per-user storage.

jburel commented 3 years ago

@will-moore could you sort this one so it is easier to review without the commits from #416?

will-moore commented 3 years ago

Rebased and pushed...

jburel commented 3 years ago

Logged as user-1, opened a figure and made a change
Disconnect
Logged as user-2, go back to the figure tab and click Save
Message indicating that an error occurred and that the figure is the local storage popped up
Login page popped up, entered the credentials of user-2.
No figure displayed as expected

jburel commented 3 years ago

The workflow using the same user works as expected

jburel commented 3 years ago

Local storage is cleared when the browser is closed.