ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO
http://figure.openmicroscopy.org
GNU Affero General Public License v3.0
15 stars 30 forks source link

Unable to save or delete specific figures #461

Open abhamacher opened 2 years ago

abhamacher commented 2 years ago

Hi Will,

I have an issue with one figure, that I can't properly save and delete. I created it some days ago and I could save it once most likely, but afterwards I could only save changes by using the "save a copy" function. I was in a hurry to prepare that figure in some variations, which resulted in four figures in my account now, which I neither can't save nor delete. I don't think I ever encountered this before and would really like to get rid of the unnecessary copies. What can I do to fix this?

fig1 One name differs, because I at least could change the file name in the top field of the web page and then the "save" button is green (just realized this today). Unfortunately the "Delete" button remains disabled all the time:

fig2

I tried it on Windows with Firefox and Chrome by the way.

Thanks, Anna

abhamacher commented 2 years ago

Ok, that was a bit silly obviously. The "Delete" button is not for the figures, but for single images. Using "file - delete" I could delete almost all files. However, one is still listed in the loading screen but completely blank when I load it. When I try to delete it, nothing happens. Still the one figure I want to keep, doesn't get an enabled "save" button, when I change something in the figure. So this might be a bug, but I have no idea how to reproduce this.

will-moore commented 2 years ago

I'm aware that some changes don't enable the Save button. But others (like dragging a panel) will do. Is that what you're seeing? If so, I'm happy to look at fixing the edits that don't enable the Save button (let me know which aren't working). If nothing is working, can you check the dev-tools Console for error messages?

And try the same for the figure that won't delete. Does the URL update when you try to open the blank figure? If so, try to refresh the page and look for errors (either when the page loads or when you try to Delete).

One alternative way you can try to delete is to attach the file to e.g. an Image (under the Attachments right-hand panel of the webclient) using the + button, then look for an existing file in the list and attach it to the Image. Then the attachment will have an unlink button as well as a Delete button. But best to check the ID of the Annotation (in the attachment tooltip) is the same ID as the Figure you're trying to delete, just to be sure you don't delete the wrong figure). Hope that makes sense.

abhamacher commented 2 years ago

Hi Will,

that misterious blank image disappeard over night. Dunno if there is some daily clean up in the database for orphans or something? At least one issue is solved now :-)

About the image that I'm unable to save -- I can do whatever I want (move panels, delete images, change labels, etc.), but the "Save" button is not being activated. In the dev console I see this output, maybe it can help you to interprete the problem:

XML Parsing Error: not well-formed Location: https://omero-cai.hhu.de/figure/load_web_figure/19920/?_=1651497313524 Line Number 1, Column 1: 19920:1:1 Error in parsing value for ‘-webkit-text-size-adjust’. Declaration dropped. bootstrap.css:45:29 Unknown property ‘orphans’. Declaration dropped. bootstrap.css:259:13 Unknown property ‘widows’. Declaration dropped. bootstrap.css:260:12 Unknown pseudo-class or pseudo-element ‘-ms-input-placeholder’. Ruleset ignored due to bad selector. bootstrap.css:1700:15 Expected ‘none’, URL, or filter function but found ‘alpha(’. Error in parsing value for ‘filter’. Declaration dropped. bootstrap.css:2035:11 Expected ‘none’, URL, or filter function but found ‘progid’. Error in parsing value for ‘filter’. Declaration dropped. bootstrap.css:3295:11 Unrecognized at-rule or error parsing at-rule ‘@-o-keyframes’. bootstrap.css:5101:14 Unknown property ‘zoom’. Declaration dropped. bootstrap.css:5206:8 Expected ‘none’, URL, or filter function but found ‘alpha(’. Error in parsing value for ‘filter’. Declaration dropped. bootstrap.css:5572:11 Expected ‘none’, URL, or filter function but found ‘alpha(’. Error in parsing value for ‘filter’. Declaration dropped. bootstrap.css:5581:11 Expected ‘none’, URL, or filter function but found ‘alpha(’. Error in parsing value for ‘filter’. Declaration dropped. bootstrap.css:5662:11 Expected ‘none’, URL, or filter function but found ‘alpha(’. Error in parsing value for ‘filter’. Declaration dropped. bootstrap.css:5667:11 Expected ‘none’, URL, or filter function but found ‘alpha(’. Error in parsing value for ‘filter’. Declaration dropped. bootstrap.css:5751:11 Expected ‘none’, URL, or filter function but found ‘alpha(’. Error in parsing value for ‘filter’. Declaration dropped. bootstrap.css:5757:11 Expected ‘none’, URL, or filter function but found ‘alpha(’. Error in parsing value for ‘filter’. Declaration dropped. bootstrap.css:6069:11 Expected ‘none’, URL, or filter function but found ‘progid’. Error in parsing value for ‘filter’. Declaration dropped. bootstrap.css:6078:11 Expected ‘none’, URL, or filter function but found ‘progid’. Error in parsing value for ‘filter’. Declaration dropped. bootstrap.css:6089:11 Expected ‘none’, URL, or filter function but found ‘alpha(’. Error in parsing value for ‘filter’. Declaration dropped. bootstrap.css:6097:11 Unrecognized at-rule or error parsing at-rule ‘@-ms-viewport’. bootstrap.css:6236:14 Unrecognized at-rule or error parsing at-rule ‘@-ms-viewport’. bootstrap.css:6241:16 Unknown property ‘-moz-border-radius’. Declaration dropped. bootstrap-colorpicker.min.css:9:329 Unknown property ‘-moz-border-radius’. Declaration dropped. bootstrap-colorpicker.min.css:9:481 Unknown property ‘-moz-border-radius’. Declaration dropped. bootstrap-colorpicker.min.css:9:1091 Expected declaration but found ‘*’. Skipped to next declaration. bootstrap-colorpicker.min.css:9:1113 Error in parsing value for ‘float’. Declaration dropped. figure.css:190:20 Expected ‘none’, URL, or filter function but found ‘progid’. Error in parsing value for ‘filter’. Declaration dropped. figure.css:717:17

will-moore commented 2 years ago

Hmmm - that looks like mostly Firefox complaining about things it doesn't recognise. I don't see so many errors on my Firefox, but even so - nothing there looks like a JavaScript error. Does the Save button say Can't Save, since that would indicate that you're editing a Figure that belongs to someone else, and the Save button would never become enabled? In this case (or even just as a workaround), you could try File -> Save a Copy.

abhamacher commented 2 years ago

I don't see any message when I move the mouse over the button. When I use the "Save a copy" function, then a new file is created and saved once, but also for this new file I cannot use the save button whatever I do or change. That's how I originally created the multiple files mentioned in my first post.

It's really weird. Unfortunately it is a big panel, which I will need to update a few more times and I'm not willing to create it once more from scratch. Copying images between browser tabs from one omero-figure to another is unfortunately not implemented yet ;-)

will-moore commented 2 years ago

I think there's a work-around that might allow you to copy and paste panels between figures...

If you open one figure, then File > open another (or File > new then save) you can move between the figures using the Forward and Back buttons on your browser. Now you can Copy from one Figure, then move to the other Figure and Paste!

This might allow you to gradually build-up a new figure from an existing one and see if the failure-to-save issue arises at a particular point.

abhamacher commented 2 years ago

Oh wow, that's nice! I'm sure that trick will save me some time in the future.

I gave it a quick try and copied this way the whole panel to a new file and I also tried to copy just one image to a new file -- in both cases I kept the disabled save-button issue. However, I realized now, when I add a completely new image to the existing panel (using the "Add Image" button) the save button gets enabled. And when I edit the file name, it is enabled too. So these are not the most elegant ways to save a figure, but at least it's a workaround. Though I still wonder, if there is something broken in our instance...

I will create several new figures within the next 3 weeks, I'll let you know, if it happens again with another figure or when I'm able to provide more information. Thanks so far!