ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO
http://figure.openmicroscopy.org
GNU Affero General Public License v3.0
15 stars 30 forks source link

Fractional LUT range entries for float pixel values #467

Closed drjrkuhn closed 1 year ago

drjrkuhn commented 2 years ago

For images with floating point pixel values, the iviewer allows one to enter fractional values for LUT min and max. Sometimes those ranges are small fractions. For example, MMP12 (Magenta) in this screenshot ranges from 0 to 0.6.

Screen Shot 2022-06-03 at 3 21 40 PM

The Omero figure interface does not properly check for floating point pixel values. Min and max accept only integer values (no decimal point). For small fractional values, the LUT display range in OMERO-figure is unable to cope.

Screen Shot 2022-06-03 at 3 21 20 PM

This image was taken with an Akoya PhenoImager. Their spectral unmixing produces float pixels.

will-moore commented 2 years ago

Looking at the iviewer code, I was expecting to see that the 'steps' (increments) of the slider to be dynamic, depending on the range. But actually it looks like the step is fixed at 0.01.

https://github.com/ome/omero-iviewer/blob/f98323a4bf24e3474537bd79195283e909dac78c/src/controls/dimension-slider.js#L293

I notice from your screenshot that only the "untouched" sliders where the value are at min/max have an increment that is smaller than 0.01. However, if this works for you then that is an easy change to apply to OMERO.figure.

will-moore commented 1 year ago

This fix is in the latest v5.0.0 release of OMERO.figure.