search

ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO
http://figure.openmicroscopy.org
GNU Affero General Public License v3.0
15 stars 30 forks source link

ROI shape fill colour #485

Open will-moore opened 1 year ago

will-moore commented 1 year ago

See https://forum.image.sc/t/couple-of-suggestions-about-omero-figure/72675

"When editing ROIs, there is not option to fill the ROI with color and transparency. Similarly, if we want to load ROIs that are filled with transparency in iviewer, only ROIs boundaries are imported into omero.figure. Is it possible to have the fill ROI option in omero.figure, either for creating and loading ROIs ?"

imagesc-bot commented 1 year ago

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/couple-of-suggestions-about-omero-figure/72675/2

Rdornier commented 7 months ago

Hello @will-moore

I have a question regarding the shapeManager. How can I do to add attribute/methods to it ? I would like to add a setFillColor method to be able to fill it but I couldn't find anything.

Thanks, All the best, Rémy.

will-moore commented 7 months ago

The shape-editor is currently a separate repo https://github.com/ome/shape-editor and installed from https://www.npmjs.com/package/@openmicroscopy/shape-editor at https://github.com/ome/omero-figure/blob/0e28536e78ecbfc4d4251afa1fcb01b5363c8254/package.json#L36

However, the original reason for that decision was to allow it's reuse elsewhere, but we have never done that so I think we could simply copy it into omero-figure.

This is what I've done in my long-running update of figure at https://github.com/ome/omero-figure/pull/477

I need to spend some time reviving that PR and fixing merge conflicts with all the updates since I started that!

Rdornier commented 7 months ago

Hi,

The shape-editor is currently a separate repo https://github.com/ome/shape-editor and installed from

That's why ! Thanks for the info

I need to spend some time reviving that PR and fixing merge conflicts with all the updates since I started that!

Do you mean that it is better to wait for that PR before we continue working on that issue ?

Rémy.