search

ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO
http://figure.openmicroscopy.org
GNU Affero General Public License v3.0
15 stars 31 forks source link

Label markdown formatting does too much #486

Open will-moore opened 2 years ago

will-moore commented 2 years ago

See https://github.com/ome/omero-figure/pull/481#issuecomment-1287137105

The markdown formatter that is used for italics and bold formatting of labels, will also format other markup. E.g. if the label starts with 4 white-spaces, it will be formatted as code (see comment above) or if starts with a - it will add a bullet point.

Probably makes sense to simply strip all white-space from user-entered text. We could also strip - and then add it back after formatting with markdown, in case user actually wants " - my label".

will-moore commented 1 year ago

Also, user may actually want text_with_underscores not to be formatted as italics. See https://forum.image.sc/t/bugs-with-labels-in-omero-figures/78829. We could give user the option to disable/enable markdown formatting for a label, but then useful italics etc wouldn't be possible. Better info on how to \_escape_ markdown might help too.

imagesc-bot commented 1 year ago

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/bugs-with-labels-in-omero-figures/78829/2

imagesc-bot commented 1 year ago

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/bugs-with-labels-in-omero-figures/78829/3