ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO
http://figure.openmicroscopy.org
GNU Affero General Public License v3.0
15 stars 31 forks source link

add cyan color to drop down menu for LUT (fix #498) #516

Closed Rdornier closed 1 year ago

Rdornier commented 1 year ago

Adding the choice for Cyan color in the display LUT. Fixing #498 issue

will-moore commented 1 year ago

Looks good!

Screenshot 2023-09-20 at 16 00 07

Rdornier commented 1 year ago

I just see now that I could also add the cyan color to scalebar / label drop down menus (to be consistent).

jburel commented 1 year ago

Should more colors options also be added to the scale bar color menu for consistency?

will-moore commented 1 year ago

@jburel I think it's a bit more work to add the "More Colors..." option to scalebar, as you need to create and handle the color-picker response. But @Rdornier might want to add the Cyan option to scalebar and label colour menus?

jburel commented 1 year ago

@will-moore Cyan has already been added and it works so let's keep it like this

will-moore commented 1 year ago

Sorry, yes I missed that (was looking after the comment at https://github.com/ome/omero-figure/pull/516#issuecomment-1727959030). So I think this is good to merge then 👍