ome / omero-figure

An OMERO.web app for creating Figures from images in OMERO
http://figure.openmicroscopy.org
GNU Affero General Public License v3.0
15 stars 30 forks source link

Manual zoom level #517

Closed Rdornier closed 8 months ago

Rdornier commented 9 months ago

Hello,

I try to make to necessary changes to add manually the zoom level (fix part of #428). However, I struggle a lot to test the changes in my dev env (i.e. changes in the code are not always taken into account when I test them). So, feel free to test and to give me feedback.

Rémy.

will-moore commented 9 months ago

Hi @Rdornier - see https://github.com/Rdornier/omero-figure/pull/1 for some fixes

Rdornier commented 9 months ago

Hi @will-moore

Many thanks for your corrective input ; it perfectly works 👍 ! I've added few more lines to update the image in the figure. I tested it and it work fine for me.

will-moore commented 9 months ago

Looking good - I think it could do with a CSS tweak. Trying this:

$ git diff
diff --git a/omero_figure/static/figure/css/figure.css b/omero_figure/static/figure/css/figure.css
index 332b657..ad108bb 100644
--- a/omero_figure/static/figure/css/figure.css
+++ b/omero_figure/static/figure/css/figure.css
@@ -233,6 +233,11 @@
         height: 14px;
         border-radius: 5px;
     }
+    #vp_zoom_value {
+        float: right;
+        width: 50px;
+        margin-top: 5px;
+    }
     .toggle_channel {

gives a nicer layout:

Screenshot 2023-09-28 at 16 36 07

imagesc-bot commented 7 months ago

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/omero-figure-crop-uses-original-image-aspect-ratio-after-rotation/89444/2