ome / omero-gallery

https://pypi.org/project/omero-gallery/
GNU Affero General Public License v3.0
5 stars 14 forks source link

Customise CSS, header and footer e.g. for IDR #26

Closed will-moore closed 4 years ago

will-moore commented 5 years ago

Do we need unique styling for IDR, different from the vanilla Gallery? For header and footer, do we simply want to be able to add links, as in the webclient TOP_LINKS or more complex html injection? Logo etc?

manics commented 5 years ago

Could you provide a config option to set an css override file? Would it be easier to have the IDR create its own downstream app that inherits from gallery and modifies django templates blocks? Is there a way to override django template templates in an existing app, e.g. by passing an additional template dir with custom files?

will-moore commented 5 years ago

Providing a config option to add a css file should be doable. I think we will probably move to using Aurelia which compiles all it's html templates into JavaScript at build / install time. So I'm not sure how easy it is to allow injection of custom HTML after that. However, we could probably leave the Header (and footer) outside of the Aurelia app and they could be built via Django.

joshmoore commented 5 years ago

Some header/footer feedback based on the current deployment:

Screen Shot 2019-06-05 at 17 38 12 ... snip ... Screen Shot 2019-06-05 at 17 38 18

will-moore commented 5 years ago

@joshmoore Thanks for the points. I think we need to discuss a bit:

will-moore commented 5 years ago

Updated header links in https://github.com/ome/omero-gallery/pull/35/commits/120d11b0d595cfc5813f053d5430f685dbcfe26e and https://github.com/IDR/idr.openmicroscopy.org/pull/55/commits/62bc2e09d06f09d4efe274034aa014305a27cf56 Screen Shot 2019-06-06 at 11 56 40

joshmoore commented 5 years ago

since they are terms coming from EBI

I imagine that's true. And a drop down?

Not sure what you mean by "auto-shrink" background?

Something like:

I think we need some page title like "Welcome to IDR".

Hmm... for the very first visit, it makes good sense. But afterwards, it find it a distraction.

will-moore commented 5 years ago

Having a page change after the first visit is a bit unusual. Never see the front page the same again after your first visit? Do this via cookies? We could remove the title from the /search pages, which is where you spend most time. Although we'd need to find some other way to know if you're in 'Cell-IDR' or 'Tissue-IDR'. Highlighting the current link in the header might help (if they're not in a drop-down menu) but I'm not sure if that's enough.