Show different subheading for /cell and /tissue

ome / omero-gallery

https://pypi.org/project/omero-gallery/

GNU Affero General Public License v3.0

5 stars 15 forks source link

Show different subheading for /cell and /tissue #37

Closed will-moore closed 5 years ago

will-moore commented 5 years ago

Tweak the text on /cell and /tissue pages.
Remove empty studies from /gallery/ e.g. /search/?query=Name:idr0028 shouldn't show the empty idr0028 study.

will-moore commented 5 years ago

https://github.com/ome/omero-gallery/pull/37/commits/fb5f565ee79e26d263aeda6444576eb8f0fb81d0 breaks thumbnails because the /gallery/gallery-api/ URL isn't 'public' now that /gallery/ is deployed at root (https://github.com/openmicroscopy/openmicroscopy/pull/6046). Other pages at e.g. /gallery/cell/ at /cell/ don't need a login.

manics commented 5 years ago

See https://github.com/IDR/deployment/pull/182

It'd be great if someone can explain the logic of why only /gallery-api needs to be added to the public filter, but /gallery doesn't.

will-moore commented 5 years ago

gallery/gallery-api/thumbnails/ is the only gallery URL that needs to allow auto-login for public user. The other pages don't need a login because they load all their data via JSON urls that are already public e.g. /api/ or /mapr/.

manics commented 5 years ago

Merging as I'm running into conflicts