Fix studies expanding outside page

ome / omero-gallery

https://pypi.org/project/omero-gallery/

GNU Affero General Public License v3.0

5 stars 14 forks source link

Fix studies expanding outside page #68

Closed will-moore closed 4 years ago

will-moore commented 4 years ago

This tweaks the css for categories page to fix the Titles and image panels expanding outside the screen:

To test:

Go to: https://merge-ci.openmicroscopy.org/web/gallery/ (login as user-3)
Resize browser window small as possible, or test on a phone.
Text and images shouldn't expand outside the page:

Before:

sbesson commented 4 years ago

Thanks. Merging. @will-moore do you want to drive and cut a patch release of omero-gallery and open a PR against https://github.com/IDR/deployment/blob/6d367a3820a2915095888ea8434aa192f791a654/ansible/group_vars/omero-hosts.yml#L215 to consume it in the next IDR release? What about the open dependency PRs?

will-moore commented 4 years ago

OK, so I remove the .dev from version as in https://github.com/ome/omero-gallery/commit/83044dc8820871d96f07dceff401763fd6bcdefd Then push a Tag for v3.3.3, then... It doesn't look like that would push a release to Pypi automatically?? Then another commit to add back 'dev' to versions.

sbesson commented 4 years ago

This might be worth a dedicated Release section in the top-level README. As far as I know, the current release process is identical to omero-py and omero-web i.e.:

review and update the CHANGELOG
run bumpversion release to remove the dev suffix and create a signed tag
run bumpversion --no-tag patch to bump the version to the next dev suffix
push the newly created tag and master to origin
the Travis CI build for the tag will also include a PyPI deployment step

https://github.com/ome/omero-gallery/blob/352a9bcc227bf35ca63a3735b19d1a641dab0af5/.travis.yml#L17-L23

will-moore commented 4 years ago

Hmm - I need some more setting up before I try this:

$ bumpversion release
error: cannot run gpg: No such file or directory
error: gpg failed to sign the data
error: unable to sign the tag

sbesson commented 4 years ago

Creating signed Git tags requires gpg installed and your private GPG key configured. You might as well want to upload your public key to GitHub - https://docs.github.com/en/github/authenticating-to-github/adding-a-new-gpg-key-to-your-github-account

will-moore commented 4 years ago

Done: $ git push origin master v3.3.3