Fix 2-cols single category

ome / omero-gallery

GNU Affero General Public License v3.0

5 stars 14 forks source link

Fix 2-cols single category #74

Closed will-moore closed 3 years ago

will-moore commented 3 years ago

Re-add class row IF only single category shown. Fixes #73 This fixes a bug from https://github.com/ome/omero-gallery/pull/68/ when used with single-category layout.

To test:

Check that you get 3 columns with single category. e.g.

omero config set omero.web.gallery.category_queries '{"all":{"label":"All Studies", "index":0, "query":"FIRST50:Name"}}'

Check that with multiple categories, still looks good on mobile (small screen) - as fixed in #68. e.g. tested locally with

omero config set omero.web.gallery.category_queries '{"all":{"label":"All Studies", "index":0, "query":"FIRST50:Name"},"idr":{"label":"IDR Studies", "index":1, "query":"Study Type: IDR"}}'

pwalczysko commented 3 years ago

Is there a workflow to reconfigure merge-ci with those lines mentioned in the header ?

will-moore commented 3 years ago

@pwalczysko If you've tested the current configuration (single category, 3 columns), I can set the 2nd config above (multi-categories) to check it's still looking good on mobile.

It is configured at https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-web/configure

pwalczysko commented 3 years ago

@pwalczysko If you've tested the current configuration (single category, 3 columns), I can set the 2nd config above (multi-categories) to check it's still looking good on mobile.

It is configured at https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-web/configure

Yes, please. In the meantime, I have tested the present state (single category, 3 columns) on my mobile and it looks and works okay (although what is referred to as "single category" ? Atm, there seems to me to be 2 categories, Name and Group...

pwalczysko commented 3 years ago

@will-moore Thanks. With 2 categories, the layout looks fine too

on Mac
on Mobile Phone (android)

Ready to merge FMPOV