Use webclient ivewer in the Default UI - Githubissues

ome / omero-gallery

https://pypi.org/project/omero-gallery/

GNU Affero General Public License v3.0

5 stars 15 forks source link

Use webclient ivewer in the Default UI #83

Closed will-moore closed 3 years ago

will-moore commented 3 years ago

The supports configuration to use e.g. iviewer as the default viewer

Fixes #82 .

To test, check that you get webclient/img_detail/ID (will be iviewer) for these viewers:

In the default gallery UI, browse Group -> Project and click thumbnail to open viewer
Click Load all Images to load all the thumbnails for a Dataset. Click on these to open viewer
Click on the Dataset Name to browse to the Dataset page. Click on thumbnail to open viewer

jburel commented 3 years ago

Screenshot 2021-03-16 at 13 45 42

If I get that correctly, the image will be opened in the default viewer, whatever is set. In our configuration, it is iviewer.

jburel commented 3 years ago

I have changed the configuration for omero-web on merge-ci, the old viewer is now the default. Clicking on a thumbnail, the old viewer is used as expected

Screenshot 2021-03-24 at 10 09 10

jburel commented 3 years ago

This PR will use whatever is set as the default viewer, this offers more flexibility and it is what a user will expect

sbesson commented 3 years ago

There have been quite a few PRs merged recently including this one addressing some user feedback. Is it worth making a quick patch release of omero-gallery (that would could consume immediately in the upcoming prod96 at the IDR level)?

jburel commented 3 years ago

I was going to propose a patch release too. @will-moore what do you think?

will-moore commented 3 years ago

Yes, it would be great to get these new features/fixes released, thanks.

jburel commented 3 years ago

Ok I will prep a release