ome / omero-gallery

https://pypi.org/project/omero-gallery/
GNU Affero General Public License v3.0
5 stars 15 forks source link

Idr front page #91

Closed will-moore closed 2 years ago

will-moore commented 2 years ago

Updates to IDR front page. Draft PR to allow others to try, feedback etc. But not intended to merge in it's current form...

TODO:

Notebooks See also https://github.com/IDR/idr.openmicroscopy.org/issues/144 and https://github.com/IDR/idr.openmicroscopy.org/pull/140

pwalczysko commented 2 years ago

thank you @will-moore 2 RFEs

  1. The top backgriound image is having a black bit to the right, is that how the image looks in original ?
  2. The Twitter column is much much longer than the block on the left with the videos, leaving a very long white space on the left when you start scrolling down the page. Could the twitter column have its own scrollbar ?
sbesson commented 2 years ago

When under either https://idr-testing.openmicroscopy.org/cell/ or https://idr-testing.openmicroscopy.org/tissue, clicking on the Cell - IDR or Tissue - IDR buttons above the search box appends /cell or /tissue to the URL and opens a broken link

sbesson commented 2 years ago

Also the thumbnails are still stretched but display with the correct aspect ratio in the tooltip

Screenshot 2022-02-09 at 09 50 39

will-moore commented 2 years ago

@sbesson I think that's a CSS caching issue again. Looks OK for me ;)

sbesson commented 2 years ago

The issues reported in https://github.com/ome/omero-gallery/pull/91#issuecomment-1033570493 were related to the deployment using https://github.com/IDR/deployment and the fact the gallery needs to be deployed on all servers (omeroreadwrite + 4 omeroreadonly) to work with the nginx caching. After fixing the deployment, the thumbnails are now displaying as expected.

Adding some feedback from @jrswedlow who performed some testing in incognito Chrome Window

  1. Carousel no longer switching
  2. As the number of thumbs grows will the palette grow so large that vids fall off bottom. Do we make the palette wider?
  3. If I go to Cell-IDR and the select Tissue-IDR or Cell-IDR, get 404 - see also https://github.com/ome/omero-gallery/pull/91#issuecomment-1033566747
  4. On thumbnail tooltip, can we add more info to help me understand what the study is? Would Publication Title or Experiment Description fit? Or maybe links to Publication and Data (not sure if we want people to leave our site, but pop up new tab?
  5. Do we add a Sort for the thumbs. Current in reverse idr order.
  6. Naive question-- any chance of elevating Imaging Method to a full search term. It's hard to find, e.g., light sheet fluorescence microscopy.
will-moore commented 2 years ago

Re: https://github.com/ome/omero-gallery/pull/91#issuecomment-1035019211

will-moore commented 2 years ago

After discussion with IDR team & Jason this morning, removed the "only show 4 rows of thumbnails" to show them all now, with a limit of ~6 rows. Also - "carousel not working" meant not auto-playing, which is as intended.

jburel commented 2 years ago

Excluding this PR. https://github.com/ome/omero-gallery/pull/93 (django upgrade has priority)

--exclude

sbesson commented 2 years ago

Capturing the output of some minimal testing of the filter box

Screenshot 2022-03-11 at 11 23 28 Screenshot 2022-03-11 at 11 24 04

A few comments:

Overall, while I think the new filtering functionality addresses a clear need, I feel like the results view does not have the same level of maturity and testing as the rest of the new UI. Whether to bring this to production immediately or as a second step is a decision we will need to make as a team.