Closed will-moore closed 2 years ago
thank you @will-moore 2 RFEs
When under either https://idr-testing.openmicroscopy.org/cell/ or https://idr-testing.openmicroscopy.org/tissue, clicking on the Cell - IDR
or Tissue - IDR
buttons above the search box appends /cell
or /tissue
to the URL and opens a broken link
Also the thumbnails are still stretched but display with the correct aspect ratio in the tooltip
@sbesson I think that's a CSS caching issue again. Looks OK for me ;)
The issues reported in https://github.com/ome/omero-gallery/pull/91#issuecomment-1033570493 were related to the deployment using https://github.com/IDR/deployment and the fact the gallery needs to be deployed on all servers (omeroreadwrite + 4 omeroreadonly) to work with the nginx caching. After fixing the deployment, the thumbnails are now displaying as expected.
Adding some feedback from @jrswedlow who performed some testing in incognito Chrome Window
Re: https://github.com/ome/omero-gallery/pull/91#issuecomment-1035019211
After discussion with IDR team & Jason this morning, removed the "only show 4 rows of thumbnails" to show them all now, with a limit of ~6 rows. Also - "carousel not working" meant not auto-playing, which is as intended.
Excluding this PR. https://github.com/ome/omero-gallery/pull/93 (django upgrade has priority)
--exclude
Capturing the output of some minimal testing of the filter box
A few comments:
Overall, while I think the new filtering functionality addresses a clear need, I feel like the results view does not have the same level of maturity and testing as the rest of the new UI. Whether to bring this to production immediately or as a second step is a decision we will need to make as a team.
Updates to IDR front page. Draft PR to allow others to try, feedback etc. But not intended to merge in it's current form...
TODO:
Notebooks See also https://github.com/IDR/idr.openmicroscopy.org/issues/144 and https://github.com/IDR/idr.openmicroscopy.org/pull/140