search

ome / omero-gateway-java

Gradle project containing OMERO Java Client Library
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
1 stars 9 forks source link

handle well column #52

Closed jburel closed 3 years ago

jburel commented 3 years ago

This PR fixes the issue noticed when working on notebook for workshop

cc @dominikl

dominikl commented 3 years ago

Looks good, thanks @jburel . Good to merge from my point of view.

jburel commented 3 years ago

@dominikl I found another place where a change was required Also why Float is not supported but Float[] is? This does not seem very logical.

jburel commented 3 years ago

Changes tested via https://github.com/ome/openmicroscopy/pull/6280

dominikl commented 3 years ago

I think this is good to merge. Could handle Float issue in a separate PR?

jburel commented 3 years ago

Tests are green see https://github.com/ome/openmicroscopy/pull/6280

jburel commented 3 years ago

Merging since the tests are green. That will allow to move forward with the work started in #56

dominikl commented 3 years ago

Thanks @jburel . Btw, there is no Float type because there is no FloatColumn: https://docs.openmicroscopy.org/omero-blitz/5.5.8/javadoc/omero/grid/Column.html .

jburel commented 3 years ago

@dominikl Thanks for pointing that out. This seems like a missing part in the spec