search

ome / omero-gateway-java

Gradle project containing OMERO Java Client Library
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
1 stars 9 forks source link

Fix tablesfacility #58

Closed dominikl closed 3 years ago

dominikl commented 3 years ago

Fixes some issues with TablesFacility; among others load referenced OMERO objects from the DB.

jburel commented 3 years ago

The change from FileAnnotationData to OriginalFile is a breaking change. Tests introduced are failing https://github.com/ome/openmicroscopy/pull/6280 See https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-test-integration/832/testngreports/integration.gateway/TablesFacilityTest/testAddTable/

joshmoore commented 3 years ago

Anything you need here, @dominikl ?

dominikl commented 3 years ago

No, should be fine now. Just waiting for @jburel to have a look / test together with https://github.com/jburel/openmicroscopy/pull/18 .

dominikl commented 3 years ago

How about logging a warning (see last commit) instead of throwing an exception @jburel ?

jburel commented 3 years ago

Logging a warning is fine. Probably nobody tried it otherwise people will have reported an issue.

jburel commented 3 years ago

Thanks @dominikl