search

ome / omero-gateway-java

Gradle project containing OMERO Java Client Library
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
1 stars 9 forks source link

Use joinsession if session id is used #62

Closed dominikl closed 2 years ago

dominikl commented 2 years ago

Bugfix for https://github.com/ome/omero-insight/issues/293 .

jburel commented 2 years ago
Screenshot 2022-05-06 at 09 25 07

insight connected using session key

dominikl commented 2 years ago

👍 I have to add this case to the integration test too.

jburel commented 2 years ago

It works the first time but not the second time SecurityViolation: 1 methods active.

Edit: actually it worked twice in a row then failed!

dominikl commented 2 years ago

Integration test: https://github.com/ome/openmicroscopy/pull/6319

dominikl commented 2 years ago

Thanks @jburel . I think that should be all cases covered now. Should now somehow be tested together with the integration test.

dominikl commented 2 years ago

Taking the discussions https://github.com/ome/openmicroscopy/pull/6319 into account: Instead of the proposed changes, shall I rather remove all calls to joinSession() and use only createSession()? This means all checks if a username is a session id can be removed too. But also implies, that if you want to login with a session id, you have to provide it as username and password. At the moment you only have to provide it as username (same for Insight).