search

ome / omero-gateway-java

Gradle project containing OMERO Java Client Library
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
1 stars 9 forks source link

Bugfix: Set StringColumn to the correct size #76

Closed dominikl closed 1 year ago

dominikl commented 1 year ago

Fixes https://github.com/ome/omero-gateway-java/issues/75 .

Tested with the idr0115 annotations. "Test" table created with the same bulk_annotations without PR. "Test_2" table created with the PR (same size as the original).

Screenshot 2023-06-09 at 10 09 40

pwalczysko commented 1 year ago

"Test" table created with the same bulk_annotations without PR. "Test_2" table created with the PR (same size as the original).

I think that the comment in the header of this PR should say "Test_2" table created without the PR :)

Tested with a short code snippet from https://github.com/ome/omero-gateway-java/issues/75 - see screenshot below

Screenshot 2023-06-13 at 14 01 44

The smaller table was created with this PR, the bigger (243 KB) without this PR.

Lgtm

imagesc-bot commented 1 year ago

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/omerotables-are-huge-why/81790/12