search

ome / omero-insight

Gradle project containing insight java client for OMERO
https://www.openmicroscopy.org/omero/
GNU General Public License v2.0
7 stars 14 forks source link

Infinite loop #401

Closed scuniff closed 10 months ago

scuniff commented 10 months ago

Looks lhis code causes an infinite loop

public void remove(String type) { this.remove(type); }

https://github.com/ome/omero-insight/blob/40566b97d28f9caf5720a55faf15c324a8c6e5de/src/main/java/org/openmicroscopy/shoola/agents/fsimporter/mde/components/ModuleList.java#L67

The code

  this.remove(type)

should be changed to

 super.remove(type)

to get to the HashMap.remove() method

jburel commented 10 months ago

fixed see https://github.com/ome/omero-insight/pull/402