ome / omero-insight

Gradle project containing insight java client for OMERO
https://www.openmicroscopy.org/omero/
GNU General Public License v2.0
7 stars 14 forks source link

Shift logic may not be correct #403

Closed scuniff closed 10 months ago

scuniff commented 10 months ago

https://github.com/ome/omero-insight/blob/40566b97d28f9caf5720a55faf15c324a8c6e5de/src/main/java/org/openmicroscopy/shoola/util/roi/model/util/Coord3D.java#L139C1-L149C3

Regarding this code:

/**

=======================

I believe the shift logic

z<<ZTBITSPLIT+t

does not do what is described in the comments.

Parenthesis are needed:

(z<<ZTBITSPLIT)+t