search

ome / omero-insight

Gradle project containing insight java client for OMERO
https://www.openmicroscopy.org/omero/
GNU General Public License v2.0
7 stars 14 forks source link

Is return keyword needed? #406

Closed scuniff closed 9 months ago

scuniff commented 10 months ago

Is return keyword needed?

https://github.com/ome/omero-insight/blob/40566b97d28f9caf5720a55faf15c324a8c6e5de/src/main/java/org/openmicroscopy/shoola/util/roi/io/InputStrategy.java#L510

        if (IOConstants.ATTRIBUTE_DATATYPE_RECTANGLE2D.equals(dataType))
            new Rectangle2D.Double(
            new Double(xValue), new Double(yValue), new Double(widthValue),
            new Double(heightValue));

should be?

        if (IOConstants.ATTRIBUTE_DATATYPE_RECTANGLE2D.equals(dataType))
            return new Rectangle2D.Double(
            new Double(xValue), new Double(yValue), new Double(widthValue),
            new Double(heightValue));
jburel commented 9 months ago

https://github.com/ome/omero-insight/pull/408