search

ome / omero-insight

Gradle project containing insight java client for OMERO
https://www.openmicroscopy.org/omero/
GNU General Public License v2.0
7 stars 14 forks source link

String.equals() should probably be used. #426

Closed scuniff closed 4 months ago

scuniff commented 6 months ago

https://github.com/ome/omero-insight/blob/4e8d0754713b0a3c74908b4ebaa9ebae4e378a14/src/main/java/org/openmicroscopy/shoola/env/ui/TaskBarView.java#L611 line 611:

      if (((JMenu) c).getText() == entry.getText()) {

should probably use String.equals(): 

                if (((JMenu) c).getText().equals(entry.getText()))

like it is at line 597

joshmoore commented 6 months ago

:+1: