search

ome / omero-insight

Gradle project containing insight java client for OMERO
https://www.openmicroscopy.org/omero/
GNU General Public License v2.0
7 stars 14 forks source link

Update apache common libs #436

Open dominikl opened 5 months ago

dominikl commented 5 months ago

I have no idea where the apache commons io dependency is defined. But lets see if this fixes https://github.com/ome/omero-insight/issues/435

jburel commented 5 months ago

commons-io is injected in omero-server There was an attempt to remove it see https://github.com/ome/omero-romio/pull/14 I don't think we should add it I think we should try to use nio Paths or Files. See for example https://github.com/ome/omero-insight/pull/268 usage of toURI to solve a similar problem

dominikl commented 5 months ago

Good idea. I'll try to remove it 👍

dominikl commented 5 months ago

Actually, not a good idea. It's everywhere. I've tried got rid of it in Insight, but then failed at https://github.com/ome/omero-insight/blob/558b56cf66c50c895fd8d5643dc377afd2a4ddee/src/main/java/org/openmicroscopy/shoola/env/data/OmeroImageServiceImpl.java#L263 with error: cannot access DirectoryWalker, icContainers = ic.getContainers(); I.e. it's heavily used in omero-blitz as well. You mentioned omero-romio... I guess it's in many many more. Which probably also means updating it to a new version is a pain.

dominikl commented 3 days ago

--exclude temporary exclude due to merge conflict