Review upload/download of artifacts in GHA

ome / omero-insight

Gradle project containing insight java client for OMERO

https://www.openmicroscopy.org/omero/

GNU General Public License v2.0

7 stars 14 forks source link

Closed omereleases closed 2 months ago

omereleases commented 2 months ago

using v4 leads to error

omereleases commented 2 months ago

v3: zip are not uploaded

sbesson commented 2 months ago

Looking at https://github.com/ome/omero-insight/actions/runs/10884718399, looks like the workflow needs to be updated to match the breaking changes in the actions if you want to move to {upload,download}-artifact@v4. In particular artifacts are no longer mutable - see also https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact

jburel commented 2 months ago

exactly I did not have time to look at that now @dominikl could you have a look?

pwalczysko commented 2 months ago

Possibly fixed by https://github.com/ome/omero-insight/pull/448 - maybe lets wait till next release to close after this :)

jburel commented 2 months ago

I think we can close it