search

ome / omero-insight

Gradle project containing insight java client for OMERO
https://www.openmicroscopy.org/omero/
GNU General Public License v2.0
7 stars 14 forks source link

Adjust the upload and download of artifacts v4 #448

Closed pwalczysko closed 2 months ago

pwalczysko commented 2 months ago

This is trying to address https://github.com/ome/omero-insight/issues/447

This branch starts from the https://github.com/ome/omero-insight/actions/runs/10884718399 - the commit a3ea82d1e59e2630ca3995ee9776a292f74e12ea -> where the build started to fail because of the same-named artifacts.

The strategy taken:

Upload:

  1. add the matrix.os motif to the artifact name -> this is by itself not enough, as we build 2 artifacts per OS on 2 occassions
  2. add a hardcoded string such as omero_ which is taken from the foldername of the path variable just below the name of the artifact

Download:

  1. adjust the file: artifacts/* -> file: artifacts*/* so that the artifacts are found in all folders created during Upload.

I have pushed an xxx-test8 tag to my private branch show-tagged-artifacts (because I do not want to push tags to this branch so as not to trigger a real release) and this resulted in Release with artifacts

cc @jburel

pwalczysko commented 2 months ago

I have pushed an xxx-test8 tag to my private branch show-tagged-artifacts (because I do not want to push tags to this branch so as not to trigger a real release) and this resulted in Release with artifacts

jburel commented 2 months ago

Tested on my account. Everything works as expected Thanks @pwalczysko