ome / omero-install

OMERO installation scripts
https://www.openmicroscopy.org/omero
4 stars 24 forks source link

Correct name of PostgreSQL setup script. #206

Closed mtbc closed 5 years ago

mtbc commented 5 years ago
$ cat /etc/centos-release
CentOS Linux release 7.6.1810 (Core) 
$ ls -l /usr/pgsql-10/bin/postgresql*setup
-rwxr-xr-x. 1 root root 9419 May  8 10:25 /usr/pgsql-10/bin/postgresql-10-setup
$ 
jburel commented 5 years ago

Strange: Travis has always been green and PG10 is the testing matrix see https://github.com/ome/omero-install/blob/develop/.travis.yml#L5

joshmoore commented 5 years ago

Feels vaguely similar to the recent issue where a bash script was failing silently. I imagine adding set -e to the proper locations would detect this type of thing.

mtbc commented 5 years ago

No idea what the Travis failures are about.

joshmoore commented 5 years ago

Looks like it never found OMERO.blitz now accepting connections in quite a few of the servers. Perhaps that script could cat the Blitz-0.log file on failure?

jburel commented 5 years ago

Having a closer look at the file, the reason travis did not fail is b/c the command is not run in docker! that's the commands run if docker container

su - postgres -c "/usr/pgsql-10/bin/initdb -D /var/lib/pgsql/10/data --encoding=UTF8"
echo "listen_addresses='*'" >> /var/lib/pgsql/10/data/postgresql.conf
jburel commented 5 years ago

Thanks for spotting that error

joshmoore commented 5 years ago

Is this a good target for trying to pin the postgres version?

mtbc commented 5 years ago

(I don't know but happy to accept whatever you and @jburel think wise.)

jburel commented 5 years ago

I think we can merge this PR as it is for 5.5.1 The change is not tested in travis and it will correct our doc. Let's hope a new pg version will be released in the coming days. Otherwise we will have to pin the version (this will require another doc release)

joshmoore commented 5 years ago

Merging along with https://github.com/ome/omero-install/pull/208#issuecomment-507703522