update pg url - Githubissues

ome / omero-install

OMERO installation scripts

https://www.openmicroscopy.org/omero

4 stars 24 forks source link

Closed jburel closed 4 years ago

jburel commented 4 years ago

This PR updates the url. The job should turn back to green see https://github.com/ome/omero-install/issues/234

When merged, we will probably need a doc release

Check that travis is green

sbesson commented 4 years ago

Travis CI is back to green and the proposed change make sense. Two minor questions:

since the yum install command is now independent of the PSQL version, is it feasible to move it before each conditional block?
also is it worth switching Travis to test PSQL11 on Centos7 as this is the recommended version?

jburel commented 4 years ago

Travis already tests pg11 by default on centos, debian and ubuntu, it is the default value in the file i.e. PGVER=${PGVER:-pg11}
the url is different from one version to the other i.e. the version number is in the url

sbesson commented 4 years ago

the url is different from one version to the other i.e. the version number is in the url

Of course. I should not review PRs as I am waking up...