search

ome / omero-install

OMERO installation scripts
https://www.openmicroscopy.org/omero
4 stars 24 forks source link

omero-certificates #252

Closed jburel closed 2 years ago

jburel commented 3 years ago

Configure omero-certifactes on CentOS 7, Without the changes, it leads to https://github.com/ome/omero-install/pull/251/checks?check_run_id=2446211596

cc @sbesson

joshmoore commented 3 years ago

Might be worth renaming the file to "install-omero-certicates" since we're no longer patching.

jburel commented 3 years ago

good point. Note that the change will modify a good number of files. I will push a commit

sbesson commented 3 years ago

Or include it as part of step04_all_omero.sh ? THis would mirror the behavior in https://github.com/ome/ansible-role-omero-server/blob/master/templates/00-omero-server-omero.j2

jburel commented 3 years ago

I will check the impact on the doc since renaming might be the easiest at this stage

jburel commented 2 years ago

Any objection to merge this PR? remaining failure in https://github.com/ome/omero-install/pull/255 will be fixed when this PR is merged

joshmoore commented 2 years ago

WFM.