ome / omero-iviewer

An OMERO.web app allowing to view images
https://www.openmicroscopy.org/omero/iviewer/
Other
19 stars 30 forks source link

Don't use tiles for non-big movies #456

Closed will-moore closed 5 months ago

will-moore commented 1 year ago

Fixes #453.

If the image is not a Big (tiled) image, then don't use tile-based loading if the image is a Movie.

will-moore commented 1 year ago

I tried deploying this on idr-testing with:

pip install git+https://github.com/will-moore/omero-iviewer.git@dont_tile_movies#egg=omero-iviewer&subdirectory=plugin
# or
pip install git+https://github.com/will-moore/omero-iviewer.git@refs/pull/74/head#egg=omero-iviewer&subdirectory=plugin

but these aren't working and I also see that we no-longer do it this way on merge-ci, where we now do:

git clone -b $MERGE_PUSH_BRANCH https://github.com/$SPACE_USER/omero-iviewer.git
cd omero-iviewer/plugin
python -m build
cd dist
for x in *.tar.gz; do
    pip install -U $x # Install iviewer
done
will-moore commented 1 year ago
$ git clone -b dont_tile_movies https://github.com/will-moore/omero-iviewer.git
$ cd omero-iviewer/plugin

$ source /opt/omero/web/venv3/bin/activate
$ sudo pip install build
$ python -m build
...
npm run prod
unable to execute 'npm': No such file or directory
error: command 'npm' failed with exit status 1

$ curl -sL https://rpm.nodesource.com/setup_16.x | sudo bash -
$ sudo yum install -y nodejs
$ sudo yum install ant
$ python -m build
...
./prepare_build.sh: line 30: ant: command not found

running run_prod
npm run prod
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /tmp/build-via-sdist-qqy51hg5/omero-iviewer-0.14.0.dev0/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/tmp/build-via-sdist-qqy51hg5/omero-iviewer-0.14.0.dev0/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/wmoore/.npm/_logs/2023-06-29T08_22_37_464Z-debug-0.log
error: command 'npm' failed with exit status 254

ERROR Backend subprocess exited when trying to invoke build_wheel
jburel commented 1 year ago

You are attempting to build from source and dependencies like ant are not installed

will-moore commented 1 year ago

I also tried adding idr.openmicroscopy.org to the server_list on merge-ci webclient so we could test IDR data in merge-ci, but login fails - which I seem to remember has been the case before.

will-moore commented 5 months ago

Closing in favour of #470