Channel min spinner fix

ome / omero-iviewer

An OMERO.web app allowing to view images

https://www.openmicroscopy.org/omero/iviewer/

Other

19 stars 30 forks source link

Open will-moore opened 1 year ago

will-moore commented 1 year ago

With a very large negative number, the formatting of the number as required for floats was resulting in Nan.
Also, the spinner behaviour (jQuery plugin) doesn't work with very large negative numbers. Reducing the minimum number fixes this issue.

jburel commented 1 year ago

is the change deployed on idr-testing?

jburel commented 6 months ago

Does this PR need to be considered for the upcoming release?

will-moore commented 6 months ago

I tried to find images where this bug was still showing, so as to demonstrate the fix, but e.g. with the image reported originally I don't see this issue any more: https://idr-testing.openmicroscopy.org/webclient/img_detail/10648053/

It's possible that some other dependency update addressed the issue? 🤷