search

ome / omero-mapr

An OMERO.web app allowing to browse the data through attributes linked to the image
https://pypi.org/project/omero-mapr/
GNU Affero General Public License v3.0
5 stars 12 forks source link

Ui fixes #12

Closed atarkowska closed 7 years ago

atarkowska commented 7 years ago

This is an umbrella PR fixing minor issues listed in https://trello.com/c/9LpdBtMl/10-web-issues

This PR requires https://github.com/openmicroscopy/openmicroscopy/pull/5014

atarkowska commented 7 years ago

This is passing against m52

+ omego download server --branch OMERO-build --ci https://10.0.51.135:8443
...
+ sed -i '' 's/^\(omero\.host\s*=\s*\).*$/\110.0.51.135/' /Users/ola/OMERO/DEV/metadata52/src/webapp.git/mapr.git/../OMERO.server/etc/ice.config
+ sed -i '' 's/^\(omero\.port\s*=\s*\).*$/\114064/' /Users/ola/OMERO/DEV/metadata52/src/webapp.git/mapr.git/../OMERO.server/etc/ice.config
...
============================================================ test session starts =============================================================
platform darwin -- Python 2.7.10, pytest-3.0.5, py-1.4.32, pluggy-0.4.0 -- /Users/ola/OMERO/DEV/metadata52/src/webapp.git/omerovenv/bin/python
cachedir: .cache
rootdir: /Users/ola/OMERO/DEV/metadata52/src/webapp.git/mapr.git, inifile: setup.cfg
plugins: django-3.1.2, logging-2015.11.4
collected 16 items 

tests/integration/test_config.py::TestMapr::test_settings PASSED
tests/integration/test_config.py::TestMapr::test_empty_settings XPASS
tests/integration/test_config.py::TestMapr::test_bad_settings[foo] PASSED
tests/integration/test_config.py::TestMapr::test_bad_settings[] PASSED
tests/integration/test_config.py::TestMapr::test_bad_settings[mygenes] PASSED
tests/integration/test_mapr.py::TestMapr::test_autocomplete[ac0] PASSED
tests/integration/test_mapr.py::TestMapr::test_autocomplete[ac1] PASSED
tests/integration/test_mapr.py::TestMapr::test_autocomplete[ac2] PASSED
tests/integration/test_mapr.py::TestMapr::test_autocomplete[ac3] PASSED
tests/unittests/test_version.py::TestUtil::test_version[version0] PASSED
tests/unittests/test_version.py::TestUtil::test_version[version1] PASSED
tests/unittests/test_version.py::TestUtil::test_version[version2] PASSED
tests/unittests/test_version.py::TestUtil::test_version[version3] PASSED
tests/unittests/test_version.py::TestUtil::test_version[version4] PASSED
tests/unittests/test_version.py::TestUtil::test_version[version5] PASSED
tests/unittests/test_version.py::TestUtil::test_version[version6] PASSED

=================================================== 15 passed, 1 xpassed in 34.38 seconds ====================================================

Looks like populate metadata plug-in in main line doesn't like particular characters. I can remove ca04ea5 test, but the rest is needed for a release

atarkowska commented 7 years ago

tests passed in https://10.0.51.135:8443/job/MAPR-test/23/console

atarkowska commented 7 years ago

I had to disable tests in travis, as metadata plugin in develop is not enough

will-moore commented 7 years ago

Code changes look reasonable. Let me know if you want me to test the UI (deployed somewhere)?

atarkowska commented 7 years ago

@will-moore link to web is in standup

joshmoore commented 7 years ago

Thanks guys. I need to tag 0.1.9 so I'm going to go ahead and merge. No objections to a 0.1.10 (and or 0.2.0) if need be.